Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree sitter dockerfile: Error on USER 1000:100 #6797

Closed
LeoniePhiline opened this issue Apr 17, 2023 · 2 comments · Fixed by #6895
Closed

Tree sitter dockerfile: Error on USER 1000:100 #6797

LeoniePhiline opened this issue Apr 17, 2023 · 2 comments · Fixed by #6895
Labels
A-language-support Area: Support for programming/text languages C-bug Category: This is a bug

Comments

@LeoniePhiline
Copy link
Contributor

Summary

USER 1000:100 breaks dockerfile tree parsing:

grafik

Scopes:

grafik

Reproduction Steps

I tried this:

  1. hx
  2. :lang dockerfile
  3. paste snippet:
FROM alpine:latest

USER 1000

RUN set -eux

I expected this to happen:

Perfect syntax highlighting.

Instead, this happened:

USER breaks highlight:

grafik

:tree-sitter-scopes shows ERROR.

Helix log

Nothing relevant.

Platform

OpenSUSE Tumbleweed - Linux

Terminal Emulator

Konsole

Helix Version

helix 4cdba7c
@LeoniePhiline LeoniePhiline added the C-bug Category: This is a bug label Apr 17, 2023
@A-Walrus
Copy link
Contributor

Looks like an upstream issue in tree-sitter-dockerfile

@the-mikedavis the-mikedavis added upstream A-language-support Area: Support for programming/text languages labels Apr 18, 2023
@LeoniePhiline LeoniePhiline mentioned this issue Apr 18, 2023
Closed
@LeoniePhiline
Copy link
Contributor Author

LeoniePhiline commented Apr 18, 2023 •
edited
Loading

We just need to update.

The issue was fixed in March 2022 in camdencheek/tree-sitter-dockerfile@71ac1e8

We reference a commit from 2021: camdencheek/tree-sitter-dockerfile@7af32bc

mcdoker18 added a commit to mcdoker18/helix that referenced this issue Apr 27, 2023
@mcdoker18
fix: update upstream tree-sitter-dockerfile
cbbf847 
Fixes: helix-editor#6797
@mcdoker18 mcdoker18 mentioned this issue Apr 27, 2023
Merged
mcdoker18 added a commit to mcdoker18/helix that referenced this issue Apr 28, 2023
@mcdoker18
fix: update upstream tree-sitter-dockerfile
a0381a6 
Fixes: helix-editor#6797
pascalkuthe pushed a commit that referenced this issue May 12, 2023
@mcdoker18
fix: update upstream tree-sitter-dockerfile (#6895)
5938e2c 
* fix: update upstream tree-sitter-dockerfile

Fixes: #6797

* fix: review

* fix: review
Triton171 pushed a commit to Triton171/helix that referenced this issue Jun 18, 2023
@mcdoker18 @Triton171
fix: update upstream tree-sitter-dockerfile (helix-editor#6895)
7c3f5d5 
* fix: update upstream tree-sitter-dockerfile

Fixes: helix-editor#6797

* fix: review

* fix: review
wes-adams pushed a commit to wes-adams/helix that referenced this issue Jul 4, 2023
@mcdoker18 @wes-adams
fix: update upstream tree-sitter-dockerfile (helix-editor#6895)
c8ae0fa 
* fix: update upstream tree-sitter-dockerfile

Fixes: helix-editor#6797

* fix: review

* fix: review
smortime pushed a commit to smortime/helix that referenced this issue Jul 10, 2024
@mcdoker18
fix: update upstream tree-sitter-dockerfile (helix-editor#6895)
5c0fafd 
* fix: update upstream tree-sitter-dockerfile

Fixes: helix-editor#6797

* fix: review

* fix: review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-language-support Area: Support for programming/text languages C-bug Category: This is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update upstream tree-sitter-dockerfile mcdoker18/helix
3 participants
@the-mikedavis @LeoniePhiline @A-Walrus