Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make system_message as optional #1038

Merged
merged 9 commits into from
Oct 13, 2024
Merged

feat: make system_message as optional #1038

merged 9 commits into from
Oct 13, 2024

Conversation

Wendong-Fan
Copy link
Member

@Wendong-Fan Wendong-Fan commented Oct 10, 2024 •
edited
Loading

Description

make system_message as optional in ChatAgent

Motivation and Context

close #1029

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@Wendong-Fan Wendong-Fan self-assigned this Oct 11, 2024
@Wendong-Fan Wendong-Fan added the enhancement New feature or request label Oct 11, 2024
@Wendong-Fan Wendong-Fan added this to the Sprint 14 milestone Oct 11, 2024
@Wendong-Fan Wendong-Fan linked an issue Oct 11, 2024 that may be closed by this pull request
[Feature Request] Make system_message optional in ChatAgent #1029
Closed
2 tasks
lightaime
lightaime reviewed Oct 11, 2024
View reviewed changes
Copy link
Member

@lightaime lightaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Leave some comments

camel/agents/chat_agent.py Show resolved Hide resolved
@Wendong-Fan Wendong-Fan marked this pull request as ready for review October 12, 2024 08:42
lightaime
lightaime approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@lightaime lightaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Wendong-Fan Wendong-Fan merged commit 1b6856d into master Oct 13, 2024
5 of 6 checks passed
@Wendong-Fan Wendong-Fan deleted the sys_msg_optional branch October 13, 2024 10:49
ZackYule pushed a commit that referenced this pull request Oct 14, 2024
@Wendong-Fan
feat: make system_message as optional (#1038)
d15aacb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightaime lightaime lightaime approved these changes

@WHALEEYE WHALEEYE Awaiting requested review from WHALEEYE

Assignees

@Wendong-Fan Wendong-Fan

Labels
enhancement New feature or request
Projects
Project Camel
Status: No status
Milestone
Sprint 14
Development

Successfully merging this pull request may close these issues.

[Feature Request] Make system_message optional in ChatAgent
2 participants
@Wendong-Fan @lightaime