Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: o1 model KeyError #1046

Merged
merged 4 commits into from
Oct 15, 2024
Merged

fix: o1 model KeyError #1046

merged 4 commits into from
Oct 15, 2024

Conversation

Wendong-Fan
Copy link
Member

@Wendong-Fan Wendong-Fan commented Oct 12, 2024

Description

fix the KeyError may raise when calling o1 model
add warming when using o1 model

Motivation and Context

close #1044 issue for o1 model error
one new issue opened to enhance unit test #1047

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@Wendong-Fan Wendong-Fan self-assigned this Oct 12, 2024
@Wendong-Fan Wendong-Fan added the bug Something isn't working label Oct 12, 2024
@Wendong-Fan Wendong-Fan added this to the Sprint 14 milestone Oct 12, 2024
@Wendong-Fan Wendong-Fan linked an issue Oct 12, 2024 that may be closed by this pull request
3 tasks
@Wendong-Fan Wendong-Fan marked this pull request as ready for review October 12, 2024 09:05
camel/models/openai_model.py Outdated Show resolved Hide resolved
@@ -1 +0,0 @@
docs.camel-ai.org
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why deteleted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cname: docs.camel-ai.org

this setting has been included in doc workflow by @WHALEEYE , so this file is not needed

Wendong-Fan and others added 2 commits October 15, 2024 22:13
@Wendong-Fan Wendong-Fan merged commit 00a0020 into master Oct 15, 2024
5 of 6 checks passed
@Wendong-Fan Wendong-Fan deleted the o1_fix branch October 15, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[BUG] O1 Preview Model Will Raise KeyError
2 participants