Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove file modify check for auto retriever #1114

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

Wendong-Fan
Copy link
Member

@Wendong-Fan Wendong-Fan commented Oct 24, 2024

Description

we used the meta data from unstructured io Element to check whether the file with same name has been modified, but this property has been removed in unstructured io v0.14.0 we are currently using, which makes the file modify check feature not available, so I remove this check temporarily before we find other way to do file modify check

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@Wendong-Fan Wendong-Fan self-assigned this Oct 24, 2024
@Wendong-Fan Wendong-Fan added the bug Something isn't working label Oct 24, 2024
@Wendong-Fan Wendong-Fan marked this pull request as ready for review October 24, 2024 09:25
@Wendong-Fan Wendong-Fan merged commit 1077847 into master Oct 24, 2024
5 of 6 checks passed
@Wendong-Fan Wendong-Fan deleted the fix-remove_file_modify_check branch October 24, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant