Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Integrate apify #1123

Merged
merged 13 commits into from
Oct 29, 2024
Merged

feat: Integrate apify #1123

merged 13 commits into from
Oct 29, 2024

Conversation

Asher-hss
Copy link
Collaborator

Description

Integrate Apify

Motivation and Context

Integrate Apify

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@Asher-hss Asher-hss marked this pull request as draft October 26, 2024 07:59
@Asher-hss Asher-hss marked this pull request as ready for review October 27, 2024 04:58
@Asher-hss Asher-hss self-assigned this Oct 27, 2024
Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Asher-hss , LGTM, left som comments below related to format

camel/loaders/apify_reader.py Show resolved Hide resolved
camel/loaders/apify_reader.py Outdated Show resolved Hide resolved
camel/loaders/apify_reader.py Outdated Show resolved Hide resolved
camel/loaders/apify_reader.py Outdated Show resolved Hide resolved
camel/loaders/apify_reader.py Outdated Show resolved Hide resolved
camel/loaders/apify_reader.py Outdated Show resolved Hide resolved
camel/loaders/apify_reader.py Outdated Show resolved Hide resolved
@Wendong-Fan Wendong-Fan changed the title Integrate apify feat: Integrate apify Oct 28, 2024
@Wendong-Fan Wendong-Fan added this to the Sprint 15 milestone Oct 28, 2024
@Wendong-Fan Wendong-Fan linked an issue Oct 28, 2024 that may be closed by this pull request
2 tasks
@Wendong-Fan
Copy link
Member

could you also update doc docs/key_modules/loaders.md to include this new feature?

@koch3092
Copy link
Collaborator

Can we obtain username information through apify

Asher-hss and others added 7 commits October 28, 2024 10:42
Co-authored-by: Wendong-Fan <133094783+Wendong-Fan@users.noreply.github.com>
Co-authored-by: Wendong-Fan <133094783+Wendong-Fan@users.noreply.github.com>
@Wendong-Fan Wendong-Fan merged commit 2c144f2 into master Oct 29, 2024
6 checks passed
@Wendong-Fan Wendong-Fan deleted the Integrate_Apify branch October 29, 2024 09:56
MuggleJinx pushed a commit that referenced this pull request Oct 30, 2024
Co-authored-by: Wendong-Fan <133094783+Wendong-Fan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Feature Request] Integrate Apify
3 participants