Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update doc and small polish #1209

Merged
merged 2 commits into from
Nov 24, 2024
Merged

chore: update doc and small polish #1209

merged 2 commits into from
Nov 24, 2024

Conversation

Wendong-Fan
Copy link
Member

Description

  1. update personal hub based on review comment
  2. update default model setting based on review comment
  3. add docstring and naming principle to contribution guideline

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@Wendong-Fan Wendong-Fan marked this pull request as ready for review November 24, 2024 11:40
@Wendong-Fan Wendong-Fan self-assigned this Nov 24, 2024
@Wendong-Fan Wendong-Fan added the documentation Improvements or additions to documentation label Nov 24, 2024
@Wendong-Fan Wendong-Fan merged commit 19530bf into master Nov 24, 2024
5 of 6 checks passed
@Wendong-Fan Wendong-Fan deleted the chore_11_24 branch November 24, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant