feat(embeddings): Add text embedding feature #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zechengz
approved these changes
Nov 19, 2023
Co-authored-by: Zecheng Zhang <zecheng@alumni.stanford.edu>
Wendong-Fan
approved these changes
Nov 19, 2023
zechengz
approved these changes
Nov 20, 2023
|
Thanks! I am reviewing this PR. Please wait a bit. |
lightaime
reviewed
Nov 20, 2023
camel/embeddings/base.py
Outdated
| r"""Abstract base class for text embedding functionalities. """ | ||
|
|
||
| @abstractmethod | ||
| def embed_texts(self, texts: List[str]) -> List[List[float]]: |
There was a problem hiding this comment.
Some embedding models are for images. We may need to consider this. Should we call it embed_queries?
There was a problem hiding this comment.
This base class is designed only for text embedding. For image embedding, we have two options: either create a separate base class specifically for image embedding or make the embed function's parameter dynamic. This would allow the program to dynamically select the appropriate overridden function during runtime.
lightaime
reviewed
Nov 21, 2023
lightaime
approved these changes
Nov 22, 2023
Co-authored-by: Guohao Li <lightaime@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add text embedding support, including a base embedding abstract class and OpenAI embedding APIs.
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213if this solves the issue #15213Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Implemented Tasks
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!