-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add AskNews toolkit #884
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ZackYule , we also need to add the dependency to toml file, but I found there's some conflict with MistralAI package, maybe we can raise one issue to see whether asknews can update their dependency version. It's would be better if can add some test code for the integration
asknews also support async running via AsyncAskNewsSDK, could we also add support for this?
can we also support
|
Hey Wendong, we just bumped httpx so that AskNews can be installed with |
Hey @robcaulk , that's awesome! Thanks so much for doing this |
Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ZackYule and sorry for the late review, the docstring format need to be aligned with other code, It would be great if we could also add some simple example code under example folder
Co-authored-by: Isaac Jin <whale3ye@gmail.com>
Description
add AskNews toolkit
Motivation and Context
close #860
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Implemented Tasks
Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!