Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Integrate What's App #972

Merged
merged 21 commits into from
Oct 17, 2024
Merged

feat: Integrate What's App #972

merged 21 commits into from
Oct 17, 2024

Conversation

Coder-Joe458
Copy link
Collaborator

@Coder-Joe458 Coder-Joe458 commented Sep 19, 2024

Description

Describe your changes in detail.

Motivation and Context

close #740

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@Wendong-Fan Wendong-Fan linked an issue Sep 19, 2024 that may be closed by this pull request
2 tasks
@Wendong-Fan Wendong-Fan added this to the Sprint 12 milestone Sep 19, 2024
@Coder-Joe458 Coder-Joe458 marked this pull request as ready for review October 1, 2024 01:55
Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Coder-Joe458 's contribution! Overall looks good, could you also add example code under examples/function_call? Thanks in advance!

camel/toolkits/whatsapp_toolkit.py Outdated Show resolved Hide resolved
camel/toolkits/whatsapp_toolkit.py Outdated Show resolved Hide resolved
Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Coder-Joe458 ! Added one more commit to unify the docstring format here: 8edcd11

LGTM

@Wendong-Fan Wendong-Fan merged commit c44640f into master Oct 17, 2024
4 of 6 checks passed
@Wendong-Fan Wendong-Fan deleted the feature/whatsapp branch October 17, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Feature Request] Integrate What's App
2 participants