Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Google scholar toolkit #997

Merged
merged 12 commits into from
Oct 16, 2024
Merged

feat: Google scholar toolkit #997

merged 12 commits into from
Oct 16, 2024

Conversation

Wendong-Fan
Copy link
Member

@Wendong-Fan Wendong-Fan commented Sep 28, 2024

Description

Add google scholar toolkit, functions supported:

  1. get_author_detailed_info
  2. get_author_publications
  3. get_publication_by_title
  4. get_full_paper_content_by_link

Motivation and Context

close #888

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@Wendong-Fan Wendong-Fan added this to the Sprint 13 milestone Sep 28, 2024
@Wendong-Fan Wendong-Fan self-assigned this Sep 28, 2024
@Wendong-Fan Wendong-Fan linked an issue Sep 28, 2024 that may be closed by this pull request
2 tasks
@Wendong-Fan Wendong-Fan marked this pull request as ready for review September 28, 2024 16:13
@lightaime
Copy link
Member

Thanks Wendong. Could we add an example that returns all the publications based on users’ scholar url? This will be the best ux.

Copy link
Collaborator

@willshang76 willshang76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we already return the OpenAIFunctions which are used by the agent, could we create an example for that to see if it really works?

@Wendong-Fan
Copy link
Member Author

@lightaime @willshang76 thanks for the quick review, have updated

@Wendong-Fan Wendong-Fan merged commit 817ed3d into master Oct 16, 2024
6 checks passed
@Wendong-Fan Wendong-Fan deleted the google_scholar branch October 16, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Feature Request] Load data from Arxiv / google scholar
3 participants