Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove model #223

Merged
merged 6 commits into from
Mar 8, 2020
Merged

Feature/remove model #223

merged 6 commits into from
Mar 8, 2020

Conversation

chinzhiweiblank
Copy link
Contributor

@chinzhiweiblank chinzhiweiblank commented Mar 2, 2020

Add a new column Remove Models.
Underneath is a button that removes the model from the model store and key from the database.
deleteModel1
deleteModel2
deleteModel3

@birm birm changed the base branch from master to develop March 4, 2020 18:50
@birm birm self-requested a review March 4, 2020 18:51
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; though I'd like to ask @Insiyaa to sanity check if they can.

@Insiyaa
Copy link
Contributor

Insiyaa commented Mar 6, 2020

Good work! I noticed that after clicking and confirming to remove the model, the entry is not removed from the table, instead the table has to be closed and opened again to see the changes. Can you please look into that?

@birm birm self-requested a review March 8, 2020 03:49
@chinzhiweiblank
Copy link
Contributor Author

@Insiyaa Rectified the issue mentioned.

@Insiyaa
Copy link
Contributor

Insiyaa commented Mar 8, 2020

Thank you, it works as required!

@birm birm merged commit 015401c into camicroscope:develop Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants