Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix #247

Closed
wants to merge 6 commits into from
Closed

Bug Fix #247

wants to merge 6 commits into from

Conversation

AbdulRashidReshamwala
Copy link
Contributor

There was a missing id attribute in the input tag which resulted in failing to add a event listner
Before
Screenshot from 2020-03-25 19-54-15
After
Screenshot from 2020-03-25 19-59-43

@birm birm requested review from birm and nanli-emory March 25, 2020 14:59
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@birm birm changed the base branch from master to develop March 25, 2020 15:18
@birm
Copy link
Member

birm commented Mar 25, 2020

Closing in favor of #249 since new commits changed the scope.

@birm birm closed this Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants