Remove deprecated links, use compose default network #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @raphink - I pinged you a couple days ago about using docker links vs networks. I'd actually not looked at the repo's compose file, just read the instructions in the readme and then adjusted them to fit.
Since the compose file is already v3, using networks instead of links pretty much means removing the 'link' syntax - docker-compose sets up a default app network and sticks all containers in a single compose file on that network, so they get connectivity out the box. This PR does that, with the caveat I don't have an oauth provider handy to test the proxy piece on so didn't tested that forwards correctly without a link set up.
The
http://terraboard:8080/terraboard/syntax remains the same without links in place though, so it probably does.