Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS ARN Support #95

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Conversation

fafalafafa
Copy link
Contributor

Enables the use of external ARN to assume role for cross-account access.

@coveralls
Copy link

coveralls commented Jun 23, 2020

Coverage Status

Coverage remained the same at 23.523% when pulling 4cf04d6 on fafalafafa:add-role-arn-support into 9adad29 on camptocamp:master.

state/aws.go Outdated
creds := stscreds.NewCredentials(sess, c.AWS.APPRoleArn)
awsConfig = &aws_sdk.Config{Credentials: creds}
} else {
log.Info("There is no role specified.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this else bit is necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right :)

@fafalafafa fafalafafa force-pushed the add-role-arn-support branch from 59b22ec to 4cf04d6 Compare June 25, 2020 15:16
@raphink raphink merged commit 76f5093 into camptocamp:master Jun 25, 2020
@raphink
Copy link
Contributor

raphink commented Jun 25, 2020

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants