Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): Checks if the gateway is already closed before trying to shutdown the gateway #104

Merged
merged 3 commits into from
Apr 14, 2020
Merged

fix(client): Checks if the gateway is already closed before trying to shutdown the gateway #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
085322c
fix(client): Checks if the gateway is already closed before trying to…
bulldetektor Apr 1, 2020
7e694ea
fix: Remove try-catch on client dispose
bulldetektor Apr 14, 2020
8017972
test(client): Verifies that the client does not throw any exceptions …
bulldetektor Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions Client.UnitTests/ZeebeClientTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,22 @@ public void ShouldThrowExceptionAfterDispose()
Assert.IsInstanceOf(typeof(ObjectDisposedException), catchedExceptions);
}

[Test]
public void ShouldNotThrowExceptionWhenDisposingMultipleTimes()
{
// given
var zeebeClient = ZeebeClient.Builder()
.UseGatewayAddress("localhost:26500")
.UsePlainText()
.Build();

// when
zeebeClient.Dispose();

// then
Assert.DoesNotThrow(() => zeebeClient.Dispose());
}

[Test]
public async Task ShouldUseTransportEncryption()
{
Expand Down
5 changes: 5 additions & 0 deletions Client/ZeebeClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,11 @@ public IPublishMessageCommandStep1 NewPublishMessageCommand()

public void Dispose()
{
if (gatewayClient is ClosedGatewayClient)
{
return;
}

gatewayClient = new ClosedGatewayClient();
channelToGateway.ShutdownAsync().Wait();
}
Expand Down