Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Corrections to JobComplete command #347

Open
jwulf opened this issue Dec 23, 2024 · 1 comment
Open

Add Corrections to JobComplete command #347

jwulf opened this issue Dec 23, 2024 · 1 comment
Assignees
Milestone

Comments

@jwulf
Copy link
Member

jwulf commented Dec 23, 2024

GRPC API - See: camunda/camunda#25947

Triage if this needs to be done for the REST API.

@jwulf jwulf added this to the 8.7.0 milestone Dec 23, 2024
@jwulf
Copy link
Member Author

jwulf commented Jan 3, 2025

The current job.complete interface takes a single object, the variables to update.

complete: (
   updatedVariables?: WorkerOutputVariables
) => Promise<JOB_ACTION_ACKNOWLEDGEMENT>

The underlying gRPC interface needs a jobKey, which is bound to the function.

But with this new functionality, it needs to take an object with the updated variables, and an optional JobResult.

So, the existing interface is not compatible with the new functionality.

Function signature override?

New method? (Easiest) job.correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant