Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repo): fix example in README (#154) #155

Merged
merged 1 commit into from
May 7, 2024
Merged

fix(repo): fix example in README (#154) #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/unit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ jobs:
- name: Build
run: npm run build

- name: Build and Smoke Test
run: npm run test:smoketest

- name: Run Unit Tests
run: |
npm run test
6 changes: 1 addition & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,7 @@ Here is an example of specifying a different cache directory via the constructor
import { Camunda8 } from '@camunda8/sdk'

const c8 = new Camunda8({
config: {
CAMUNDA_TOKEN_CACHE_DIR: '/tmp/cache',
},
CAMUNDA_TOKEN_CACHE_DIR: '/tmp/cache',
})
```

Expand Down Expand Up @@ -149,7 +147,6 @@ Here is an example of doing this via the constructor, rather than via the enviro
import { Camunda8 } from '@camunda8/sdk'

const c8 = new Camunda8({
config: {
ZEEBE_ADDRESS: 'localhost:26500'
ZEEBE_CLIENT_ID: 'zeebe'
ZEEBE_CLIENT_SECRET: 'zecret'
Expand All @@ -160,7 +157,6 @@ const c8 = new Camunda8({
CAMUNDA_MODELER_BASE_URL: 'http://localhost:8070/api'
CAMUNDA_TENANT_ID: '' // We can override values in the env by passing an empty string value
CAMUNDA_SECURE_CONNECTION: false
}
})
```

Expand Down
Loading