fix(issue137): support ZEEBE_REST_ADDRESS and ZEEBE_GRPC_ADDRESS envi… #159
+40
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ronment variables
|
@jwulf would you like me to update all the unit tests as well with these new variables ? |
|
@hassan-alnator sure, let's make the unit tests use the new env vars. But we should also keep sufficient coverage to make sure that we continue to support the original variable name. |
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2024
## [8.5.4-alpha.2](v8.5.4-alpha.1...v8.5.4-alpha.2) (2024-05-22) ### Bug Fixes * **issue137:** support ZEEBE_REST_ADDRESS and ZEEBE_GRPC_ADDRESS environment variables ([#159](#159)) ([41fdca0](41fdca0)) * **oauth:** correctly expire cached token ([#164](#164)) ([c86e550](c86e550)), closes [#163](#163) ### Features * **zeebe:** support Zeebe User Task REST API ([022607b](022607b)), closes [#34](#34)
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2024
## [8.5.4-alpha.2](v8.5.4-alpha.1...v8.5.4-alpha.2) (2024-05-22) ### Bug Fixes * **issue137:** support ZEEBE_REST_ADDRESS and ZEEBE_GRPC_ADDRESS environment variables ([#159](#159)) ([41fdca0](41fdca0)) * **oauth:** correctly expire cached token ([#164](#164)) ([c86e550](c86e550)), closes [#163](#163) ### Features * **zeebe:** support Zeebe User Task REST API ([022607b](022607b)), closes [#34](#34)
github-actions bot
pushed a commit
that referenced
this pull request
May 24, 2024
## [8.5.4](v8.5.3...v8.5.4) (2024-05-24) ### Bug Fixes * **issue137:** support ZEEBE_REST_ADDRESS and ZEEBE_GRPC_ADDRESS environment variables ([#159](#159)) ([41fdca0](41fdca0)) * **oauth:** correctly expire cached token ([#164](#164)) ([c86e550](c86e550)), closes [#163](#163) ### Features * **camunda8:** support Basic Auth ([d6acdfd](d6acdfd)), closes [#165](#165) * **oauth:** add conditional loading of client key and cert for getting a token ([#161](#161)) ([f05aa8a](f05aa8a)) * **zeebe:** support Zeebe User Task REST API ([022607b](022607b)), closes [#34](#34)
github-actions bot
pushed a commit
that referenced
this pull request
May 24, 2024
## [8.5.4](v8.5.3...v8.5.4) (2024-05-24) ### Bug Fixes * **issue137:** support ZEEBE_REST_ADDRESS and ZEEBE_GRPC_ADDRESS environment variables ([#159](#159)) ([41fdca0](41fdca0)) * **oauth:** correctly expire cached token ([#164](#164)) ([c86e550](c86e550)), closes [#163](#163) ### Features * **camunda8:** support Basic Auth ([d6acdfd](d6acdfd)), closes [#165](#165) * **oauth:** add conditional loading of client key and cert for getting a token ([#161](#161)) ([f05aa8a](f05aa8a)) * **zeebe:** support Zeebe User Task REST API ([022607b](022607b)), closes [#34](#34)
hassan-alnator
had a problem deploying
to
integration
GitHub Actions
Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding support for ZEEBE_REST_ADDRESS and ZEEBE_GRPC_ADDRESS in the configuration as well as the ZeebeGrpcClient also updating all the MD files with the new environment variables.