fix(openApi): add missing schema declarations #4808
Merged
+28
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHWaechtler
requested review from
joaquinfelici and
tasso94
and removed request for
joaquinfelici
1 task
|
Successfully created backport PR for
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #3298
Adds missing schema declarations for:
/job/aJobId/stacktracehistory/job-log/someId/stacktraceI noticed that there was no attribute for the response macro to add this declaration for string responses, instead of defaulting to the "manual" approach I adjusted the macro to add a
contenctDescfield as that seemed cleaner to me - let me know if there is a reason not to have this added there though and we can instead rewrite the above without using the macros.While I was there I also noticed it was missing for
history/external-task-log/someId/error-detailsso this adds it for that too. Also adjusts the equivalent inexternal-task/someId/errorDetailsjust for consistency.