Remove zeebe:bindingType unless allowed
#78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippfromme
changed the title
zeebe:bindingType unless allowedzeebe:bindingType unless allowed
4 tasks
nikku
reviewed
Jul 25, 2024
| const formDefinition = getFormDefinition(userTask); | ||
|
|
||
| expect(formDefinition.get('bindingType')).to.equal('latest'); // default value | ||
| expect(formDefinition.get('formId')).not.to.exist; |
There was a problem hiding this comment.
What UX flow do we support here? Is it really a use-case to set bindingType which internally sets formId? I'd assume this is "undefined behavior", in case this is not in the happy path.
There was a problem hiding this comment.
On the otherhand this is well tested and simple enough; just wondering what is our strategy here.
There was a problem hiding this comment.
It's not possible through the properties panel since the Binding field only appears once a formId has been set. But users of the API could technically set the bindingType directly.
nikku
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zeebe:bindingTypewhenzeebe:formId(linked Camunda form) is removedzeebe:formIdwhenzeebe:bindingTypeis setRelated to camunda/camunda-modeler#4385