Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create new user task form only if user task form referenced #85

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

philippfromme
Copy link
Collaborator

  • does not create a new form definition, instead it only creates a new user task form and references it
  • does not create a new user task form if there is no existing user task form already referenced by another form definition

brave_eb3OYVaM4K

Related to camunda/camunda-modeler#4658

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 1, 2024
@philippfromme philippfromme force-pushed the fix-user-task-form-behavior branch from fe4958a to 32a85d3 Compare November 1, 2024 14:02
@philippfromme philippfromme requested review from nikku and barmac November 1, 2024 14:04
@abdul99ahad
Copy link

Works as expected. Just a quick question. When you copy and paste the user task with linked form , it will create a new form with the same form ID? or will it reference the same form?

@barmac barmac force-pushed the fix-user-task-form-behavior branch from 32a85d3 to 5a24b0e Compare November 15, 2024 14:58
Copy link
Contributor

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

@nikku
Copy link
Member

nikku commented Nov 19, 2024

@philippfromme This is pending integration 🙃

@philippfromme philippfromme merged commit b86489b into main Nov 19, 2024
4 of 5 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 19, 2024
@philippfromme philippfromme deleted the fix-user-task-form-behavior branch November 19, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants