feat: default user tasks with zeebe:UserTask extension element

[Skaiir]

Related to camunda/camunda-modeler#4648

[philippfromme]

What is the state of this pull request?

[Skaiir]

This is currently in draft because there are some failing tests around userTaskForm. Getting some help from @philippfromme to get this unblocked.

[barmac]

I will look into this now.

[barmac]

Since @philippfromme's test update is merged now, let's run it on CI again.

[barmac]

Regarding the failing CleanUpTaskListenersBehaviorSpec test case, we could remove it as it cannot be reproduced in the UI (task listener on job worker user task).

[barmac]

Done via 44dd8bd

[barmac]

I suspect that the remaining test cases might be failing because we change from job worker to zeebe user task, so specifically related to the content of the PR.

What about if we consider changing the editor's behaviour via a popup menu / context pad extension? So that we don't need to add the extension after the element is created, but rather create a proper user task from the beginning? This could have a down (or up?) side of being able to copy and paste a job-worker user task. What do you think @Skaiir ?

[philippfromme]

I think using a behavior is the right approach here. We are using the same pattern for similar cases already. We just need to make sure the behaviors aren't conflicting with each other.

[barmac]

Whatever solution we take, let's make sure these requirements are met:

• When I create a user task from scratch, its implementation is set to Zeebe user task
• When I replace a task with user task, its implementation is set to Zeebe user task
• When I copy a job worker user task, the implementation type is kept

[Skaiir]

I have adjusted the behavior to act on replace, and not do so on copy. Struggled with that second part but GPT found the hint in the context regarding how to differentiate a regular creation from a copy creation.

Then I looked it up in the bpmn-js codebase and it seems to be the proper way: bpmn-io/bpmn-js@bf18032#diff-2f0de25761fb7459e88071f83fd845c5R22.

===

Regarding the leftover failing tests. I don't know this form behavior and I'm not sure what the expectations are, but it seems that it is only applicable for non-zeebe userTasks. The simple fix I could find to clear the last couple tests to green was to bypass the zeebe:UserTask behavior in those tests by setting the "copy" hint directly. It basically emulates what would happen in a copy scenario.

[barmac]

I'll have a look into this tomorrow.

[barmac]

Thanks @Skaiir for a great review session together. I will implement the changes where we marked it with comments and release it today afternoon.

[barmac]

I've applied the changes ideated in the review session, cf. dc78601

[barmac]

Thanks @Skaiir for providing this

[barmac]

Released as v1.8.0