Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(copy/paste): allow copy/paste of camunda:ErrorEventDefinition errorRefs #68

Merged
merged 9 commits into from
Mar 24, 2021

Conversation

azeghers
Copy link
Contributor

@azeghers azeghers commented Mar 23, 2021

This PR adds the missing errorRef in the camunda:ErrorEventDefinition elements when copy/pasting a service task.

It also adds karma to allow for the integration testing of the behavior.
In its current state, the testing script is broken as there is an import conflict I would need some help fixing.


Related to bpmn-io/bpmn-js-properties-panel#442

@azeghers azeghers requested review from nikku and philippfromme March 23, 2021 15:05
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Mar 23, 2021
@nikku nikku removed the request for review from philippfromme March 23, 2021 17:46
@nikku nikku marked this pull request as ready for review March 24, 2021 12:24
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Mar 24, 2021
@nikku
Copy link
Member

nikku commented Mar 24, 2021

Pushed some cleanups on top and will release this one as a pre-release.

@nikku nikku merged commit 80ba46f into master Mar 24, 2021
@nikku nikku deleted the root-element-reference-behavior branch March 24, 2021 12:25
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 24, 2021
@philippfromme
Copy link
Contributor

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants