Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package names in ConnectorJobHandler example #4518

Merged
merged 6 commits into from
Nov 18, 2024

Conversation

itsmestefanjay
Copy link
Contributor

@itsmestefanjay itsmestefanjay commented Oct 25, 2024

Description

I discovered some differences in the docs and the actual Connector SDK's package names, going back to at least 8.3. This PR fixes the docs

component: connectors

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@akeller akeller added component:connectors Issues related to the connectors project. kind/bug Issues related with bugs in the documentation labels Oct 25, 2024
@akeller akeller requested a review from sbuettner October 25, 2024 20:33
@akeller
Copy link
Member

akeller commented Oct 25, 2024

@itsmestefanjay thanks for your PR! I followed up internally to get this reviewed and merged.

@@ -1087,7 +1088,7 @@ public class Main {

zeebeClient.newWorker()
.jobType("io.camunda:template:1")
.handler(new ConnectorJobHandler(new MyConnectorFunction()))
.handler(new ConnectorJobHandler(new MyConnectorFunction(), new DefaultValidationProvider()))
Copy link
Contributor

@sbuettner sbuettner Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the actual code I am wondering whether this constructor is even supported anymore beside testing purposes.

As the execution requires more dependencies to be in place beside the validation provider, see https://github.com/camunda/connectors-bundle/blob/9e427e9cc83f21a8f0b576b37ef36c21faa5fcdc/connector-runtime/connector-runtime-core/src/main/java/io/camunda/connector/runtime/core/outbound/ConnectorJobHandler.java#L188

cc @chillleader wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbuettner @chillleader please follow up and open a new PR if action is required here.

@akeller akeller merged commit 4d96672 into camunda:main Nov 18, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:connectors Issues related to the connectors project. kind/bug Issues related with bugs in the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants