-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix package names in ConnectorJobHandler example #4518
Conversation
@itsmestefanjay thanks for your PR! I followed up internally to get this reviewed and merged. |
@@ -1087,7 +1088,7 @@ public class Main { | |||
|
|||
zeebeClient.newWorker() | |||
.jobType("io.camunda:template:1") | |||
.handler(new ConnectorJobHandler(new MyConnectorFunction())) | |||
.handler(new ConnectorJobHandler(new MyConnectorFunction(), new DefaultValidationProvider())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the actual code I am wondering whether this constructor is even supported anymore beside testing purposes.
As the execution requires more dependencies to be in place beside the validation provider, see https://github.com/camunda/connectors-bundle/blob/9e427e9cc83f21a8f0b576b37ef36c21faa5fcdc/connector-runtime/connector-runtime-core/src/main/java/io/camunda/connector/runtime/core/outbound/ConnectorJobHandler.java#L188
cc @chillleader wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbuettner @chillleader please follow up and open a new PR if action is required here.
Description
I discovered some differences in the docs and the actual Connector SDK's package names, going back to at least 8.3. This PR fixes the docs
component: connectors
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).