Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the oidc instructions to update deprecated MS Entra steps #4887

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

conceptualshark
Copy link
Contributor

Description

The OIDC page references the app manifest in Azure AD Graph format, which has been deprecated and now now longer accessible as of January 7: https://learn.microsoft.com/en-us/entra/identity-platform/azure-active-directory-graph-app-manifest-deprecation#convert-an-app-manifest-in-azure-ad-graph-format-to-microsoft-graph-format

This PR updates the link to the new steps, updates the attribute to the correct reference, and updates the example to the new attribute name.

Internal slack: https://camunda.slack.com/archives/C026U8GBNSW/p1737545424357219

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support. (add bug or support label)
  • This is already available but undocumented and should be released within a week. (add available & undocumented label)
  • This is on a specific schedule and the assignee will coordinate a release with the DevEx team. (create draft PR and/or add hold label)
  • This is part of a scheduled alpha or minor. (add alpha or minor label)
  • There is no urgency with this change (add low prio label)

PR Checklist

  • My changes are for the next minor and are in /docs directory (aka /next/).
  • My changes are for an already released minor and are in /versioned_docs directory.

Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - no changes - nice job! 🔥 🚀

@akeller akeller added the low prio There is no urgency with this change. label Jan 22, 2025
@akeller
Copy link
Member

akeller commented Jan 22, 2025

I added the low prio label based on the checklist, but this looks more like a bug. I would like to see this fixed ASAP, if possible, as it looks like a quick win to review and merge. However, I'm not confident I can provide a review for technical accuracy.

Copy link
Contributor

@Ben-Sheppard Ben-Sheppard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side :) - I just wanted to double check one of our test apps in Entra and these instructions match! Thank you for handling this @conceptualshark

@akeller akeller merged commit a93b34e into main Jan 23, 2025
12 checks passed
@akeller akeller deleted the cg-entra-update branch January 23, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low prio There is no urgency with this change.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants