Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version tag linting broken #4519

Closed
philippfromme opened this issue Sep 11, 2024 · 0 comments · Fixed by #4529
Closed

Version tag linting broken #4519

philippfromme opened this issue Sep 11, 2024 · 0 comments · Fixed by #4529
Assignees
@philippfromme
Labels
bug Something isn't working
Milestone
M81

Comments

@philippfromme
Copy link
Contributor

philippfromme commented Sep 11, 2024 •
edited
Loading

Describe the bug

There are two issues with how the binding by version tag is being linted:

  1. If binding by version tag is chosen and the version tag is empty no lint error is shown

image

  1. If binding by version tag is chosen and not supported a lint error is shown for both the binding and the version tag

image

Environment

  • Camunda Modeler Version: 5.27

Additional context

Related to #4513 (comment)
@philippfromme philippfromme added the bug Something isn't working label Sep 11, 2024
@philippfromme philippfromme self-assigned this Sep 11, 2024
@philippfromme philippfromme added the in progress Currently worked on label Sep 11, 2024
@philippfromme philippfromme changed the title _Version tag_ linting broken Version tag linting broken Sep 11, 2024
@philippfromme philippfromme added fixed upstream Requires integration of upstream change and removed in progress Currently worked on labels Sep 11, 2024
@philippfromme philippfromme mentioned this issue Sep 11, 2024
Merged
4 tasks
@bpmn-io-tasks bpmn-io-tasks bot removed the fixed upstream Requires integration of upstream change label Sep 11, 2024
@philippfromme philippfromme reopened this Sep 11, 2024
@github-actions github-actions bot added this to the M81 milestone Sep 11, 2024
philippfromme added a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Sep 11, 2024
@philippfromme
fix(no-version-tag): do not lint zeebe:versionTag attribute
d64e2e3 
An error will be reported by the `no-binding-type` rule so we don't need another error for the version tag itself.

Related to camunda/camunda-modeler#4519
philippfromme added a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Sep 11, 2024
@philippfromme
feat: add version-tag rule
b0a0569 
Related to camunda/camunda-modeler#4519
@philippfromme philippfromme mentioned this issue Sep 11, 2024
Merged
philippfromme added a commit to camunda/linting that referenced this issue Sep 11, 2024
@philippfromme
feat: update no-version-tag rule and add version-tag rule
4220346 
Related to camunda/camunda-modeler#4519
@philippfromme philippfromme mentioned this issue Sep 11, 2024
Merged
@nikku nikku added the in progress Currently worked on label Sep 16, 2024
nikku pushed a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Sep 16, 2024
@philippfromme @nikku
fix(no-version-tag): do not lint zeebe:versionTag attribute
8b9dacb 
An error will be reported by the `no-binding-type` rule so we don't need another error for the version tag itself.

Related to camunda/camunda-modeler#4519
nikku pushed a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Sep 16, 2024
@philippfromme @nikku
feat: add version-tag rule
789c51c 
Related to camunda/camunda-modeler#4519
nikku added a commit to camunda/linting that referenced this issue Sep 16, 2024
@nikku
deps: update to bpmnlint-plugin-camunda-compat@2.26.0
d24d8c6 
fix: prevent double-linting of version tag field

  Related to camunda/camunda-modeler#4519
philippfromme pushed a commit to camunda/linting that referenced this issue Sep 17, 2024
@nikku @philippfromme
deps: update to bpmnlint-plugin-camunda-compat@2.26.0
1eb6a55 
fix: prevent double-linting of version tag field

  Related to camunda/camunda-modeler#4519
philippfromme added a commit to camunda/linting that referenced this issue Sep 17, 2024
@philippfromme
feat: update no-version-tag rule and add version-tag rule
9242cff 
Related to camunda/camunda-modeler#4519
nikku added a commit to camunda/linting that referenced this issue Sep 17, 2024
@nikku
deps: update to bpmnlint-plugin-camunda-compat@2.26.0
0f8ab2a 
fix: prevent double-linting of version tag field

  Related to camunda/camunda-modeler#4519
nikku pushed a commit to camunda/linting that referenced this issue Sep 17, 2024
@philippfromme @nikku
feat: update no-version-tag rule and add version-tag rule
47573fb 
Related to camunda/camunda-modeler#4519
@philippfromme philippfromme added the fixed upstream Requires integration of upstream change label Sep 17, 2024 — with bpmn-io-tasks
@philippfromme philippfromme removed the in progress Currently worked on label Sep 17, 2024
philippfromme pushed a commit to camunda/linting that referenced this issue Sep 18, 2024
@nikku @philippfromme
deps: update to bpmnlint-plugin-camunda-compat@2.26.0
e1fdc5d 
fix: prevent double-linting of version tag field

  Related to camunda/camunda-modeler#4519
philippfromme added a commit to camunda/linting that referenced this issue Sep 18, 2024
@philippfromme
feat: update no-version-tag rule and add version-tag rule
55d1003 
Related to camunda/camunda-modeler#4519
@philippfromme philippfromme mentioned this issue Sep 18, 2024
Merged
4 tasks
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Sep 18, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the fixed upstream Requires integration of upstream change label Sep 18, 2024
philippfromme added a commit that referenced this issue Sep 18, 2024
@philippfromme
deps: update @camunda/linting to v3.27.0
cdde2be 
Closes #4519
nikku pushed a commit that referenced this issue Sep 18, 2024
@philippfromme @nikku
deps: update @camunda/linting to v3.27.0
0682c9d 
Closes #4519
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 18, 2024
@nikku nikku mentioned this issue Sep 22, 2024
Closed
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippfromme philippfromme

Labels
bug Something isn't working
Projects
None yet
Milestone
M81
Development

Successfully merging a pull request may close this issue.

deps: update @camunda/linting to v3.27.0 camunda/camunda-modeler
2 participants
@nikku @philippfromme