Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename user task listeners event types #4748

Closed
4 tasks done
barmac opened this issue Dec 11, 2024 · 0 comments
Closed
4 tasks done

Rename user task listeners event types #4748

barmac opened this issue Dec 11, 2024 · 0 comments
Assignees
@barmac
Labels
Camunda 8 Flags an issue as related to Camunda 8
Milestone
M84

Comments

@barmac
Copy link
Collaborator

barmac commented Dec 11, 2024 •
edited
Loading

What should we do?

  • Task listener event type can be set to one of [ 'assigning', 'completing' ]
  • I can see the legacy value (assignment, complete) in the UI
  • Change is one way, so I can change to the new values but cannot come back
  • camunda-bpmn-js-behaviors are adjusted but don't remove legacy names

This can be done now or for the 8.8 release cycle.

Why should we do it?

Related to https://github.com/camunda/product-hub/issues/1822#issuecomment-2534564326
@barmac barmac added ready Ready to be worked on Camunda 8 Flags an issue as related to Camunda 8 labels Dec 11, 2024
@korthout korthout mentioned this issue Dec 11, 2024
Closed
@barmac barmac self-assigned this Dec 12, 2024
barmac added a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Dec 12, 2024
@barmac
test: verify new task listener event
7389da2 
This is to confirm that the event type still works.

Related to camunda/camunda-modeler#4748
@barmac barmac mentioned this issue Dec 12, 2024
Merged
barmac added a commit to camunda/camunda-bpmn-js-behaviors that referenced this issue Dec 12, 2024
@barmac
feat: relax zeebe:TaskListeners cleanup based on event types
40b7020 
Related to camunda/camunda-modeler#4748
@barmac barmac mentioned this issue Dec 12, 2024
Merged
barmac added a commit to camunda/camunda-bpmn-js-behaviors that referenced this issue Dec 12, 2024
@barmac
feat: relax zeebe:TaskListeners cleanup based on event types
b13f47e 
Related to camunda/camunda-modeler#4748
barmac added a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Dec 12, 2024
@barmac
feat: rename task listener event types
8a3467f 
Related to camunda/camunda-modeler#4748
@barmac barmac mentioned this issue Dec 12, 2024
Merged
4 tasks
nikku pushed a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Dec 13, 2024
@barmac @nikku
test: verify new task listener event
0598854 
This is to confirm that the event type still works.

Related to camunda/camunda-modeler#4748
@barmac barmac added this to the M84 milestone Dec 13, 2024
barmac added a commit to camunda/camunda-bpmn-js-behaviors that referenced this issue Dec 13, 2024
@barmac
feat: relax zeebe:TaskListeners cleanup based on event types
6151ed9 
Related to camunda/camunda-modeler#4748
barmac added a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Dec 13, 2024
@barmac
feat: rename task listener event types
b250a19 
Related to camunda/camunda-modeler#4748
barmac added a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Dec 13, 2024
@barmac
feat: rename task listener event types
9a6aa44 
Related to camunda/camunda-modeler#4748
@barmac barmac added fixed upstream Requires integration of upstream change and removed ready Ready to be worked on labels Dec 13, 2024
@barmac barmac closed this as completed in 5f6b59b Dec 13, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the fixed upstream Requires integration of upstream change label Dec 13, 2024
@barmac barmac mentioned this issue Dec 18, 2024
Open
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
Camunda 8 Flags an issue as related to Camunda 8
Projects
None yet
Milestone
M84
Development

No branches or pull requests
1 participant
@barmac