Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use gatewayAddress property instead of brokerContactPoint #1647

Merged
merged 7 commits into from
Jun 20, 2024
Merged

refactor: use gatewayAddress property instead of brokerContactPoint #1647

merged 7 commits into from
Jun 20, 2024

Conversation

romansmirnov
Copy link
Member

@romansmirnov romansmirnov commented Apr 18, 2024 •
edited
Loading

Which problem does the PR fix?

closes #1646

What's in this PR?

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@romansmirnov romansmirnov mentioned this pull request Apr 18, 2024
Closed
2 tasks
@houssain-barouni houssain-barouni mentioned this pull request Apr 30, 2024
Merged
6 tasks
@aabouzaid aabouzaid force-pushed the main branch 7 times, most recently from f0da3dc to c374f10 Compare June 6, 2024 14:29
@ChrisKujawa ChrisKujawa mentioned this pull request Jun 14, 2024
Merged
6 tasks
@houssain-barouni houssain-barouni force-pushed the rs-operate-gateway-address branch from 0863b79 to 0a8725f Compare June 19, 2024 14:29
@houssain-barouni houssain-barouni force-pushed the rs-operate-gateway-address branch from 0a8725f to 199324e Compare June 19, 2024 14:31
@houssain-barouni houssain-barouni added the version/8.6 Camunda applications/cycle version label Jun 19, 2024
@aabouzaid aabouzaid force-pushed the rs-operate-gateway-address branch from 199324e to 0700d74 Compare June 19, 2024 19:58
aabouzaid
aabouzaid approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@aabouzaid aabouzaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 👍

@aabouzaid aabouzaid merged commit 71b9215 into main Jun 20, 2024
10 checks passed
@aabouzaid aabouzaid deleted the rs-operate-gateway-address branch June 20, 2024 10:04
@aabouzaid aabouzaid changed the title fix: use gatewayAddress property instead of brokerContactPoint refactor: use gatewayAddress property instead of brokerContactPoint Jun 20, 2024
aabouzaid pushed a commit that referenced this pull request Jul 13, 2024
@romansmirnov @houssain-barouni @aabouzaid
refactor: use gatewayAddress property instead of brokerContactPoint (#…
eb6f179 
…1647)

Co-authored-by: Houssain Barouni <houssain.barouni@camunda.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabouzaid aabouzaid aabouzaid approved these changes

Assignees

@romansmirnov romansmirnov

@houssain-barouni houssain-barouni

Labels
kind/refactor version/8.6 Camunda applications/cycle version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK] Make use of the gatewayAddress property instead of the deprecated brokerContactPoint in Operate
3 participants
@romansmirnov @aabouzaid @houssain-barouni