Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web-modeler): reference docker hub images #1974

Merged
merged 1 commit into from
Jun 26, 2024
Merged

feat(web-modeler): reference docker hub images #1974

merged 1 commit into from
Jun 26, 2024

Conversation

wollefitz
Copy link
Member

@wollefitz wollefitz commented Jun 7, 2024 •
edited
Loading

Which problem does the PR fix?

Closes https://github.com/camunda/distribution/issues/256

What's in this PR?

References Web Modeler's public images (>= 8.6.0-alpha2) instead of the private ones

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@wollefitz wollefitz force-pushed the 256-web-modeler-docker-hub branch 4 times, most recently from 1b8cc85 to 98eb97f Compare June 10, 2024 13:54
@wollefitz wollefitz closed this Jun 25, 2024
@wollefitz wollefitz force-pushed the 256-web-modeler-docker-hub branch from 98eb97f to d8b0ee1 Compare June 25, 2024 21:37
@wollefitz wollefitz reopened this Jun 25, 2024
@wollefitz wollefitz marked this pull request as ready for review June 25, 2024 21:39
@wollefitz
Copy link
Member Author

This is unblocked now that there are the camunda-platform-alpha charts, cc @JacobiCamunda

@wollefitz wollefitz requested a review from a team June 25, 2024 21:42
@wollefitz wollefitz force-pushed the 256-web-modeler-docker-hub branch 3 times, most recently from e5d7c18 to 1296779 Compare June 25, 2024 21:57
@wollefitz @aabouzaid
feat(web-modeler): reference docker hub images
301d93e 
Signed-off-by: Ahmed AbouZaid <6760103+aabouzaid@users.noreply.github.com>
@aabouzaid aabouzaid force-pushed the 256-web-modeler-docker-hub branch from 3fea5ba to c7ac3e6 Compare June 26, 2024 18:16
@aabouzaid aabouzaid requested review from aabouzaid and removed request for a team June 26, 2024 18:16
@aabouzaid aabouzaid force-pushed the 256-web-modeler-docker-hub branch 2 times, most recently from c6f0ae3 to 301d93e Compare June 26, 2024 18:18
aabouzaid
aabouzaid approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@aabouzaid aabouzaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort 🙌
Regarding the failed jobs, it's an issue in the CI and I'm on it now.
So I will merge the PR.

@aabouzaid aabouzaid enabled auto-merge (squash) June 26, 2024 18:21
@aabouzaid aabouzaid disabled auto-merge June 26, 2024 18:21
@aabouzaid aabouzaid merged commit bfe2396 into main Jun 26, 2024
18 of 34 checks passed
@aabouzaid aabouzaid deleted the 256-web-modeler-docker-hub branch June 26, 2024 18:22
@aabouzaid aabouzaid added the kind/enhancement New feature or request label Jun 26, 2024
@distro-ci distro-ci bot mentioned this pull request Jun 26, 2024
Merged
aabouzaid pushed a commit that referenced this pull request Jun 27, 2024
@wollefitz @aabouzaid
feat: use web-modeler public docker images (#1974)
5c620a8
leiicamundi pushed a commit that referenced this pull request Jun 27, 2024
@wollefitz @leiicamundi
feat: use web-modeler public docker images (#1974)
7cc1eb9
aabouzaid pushed a commit that referenced this pull request Jun 28, 2024
@wollefitz @aabouzaid
feat: use web-modeler public docker images (#1974)
fb9d039
aabouzaid pushed a commit that referenced this pull request Jul 13, 2024
@wollefitz @aabouzaid
feat: use web-modeler public docker images (#1974)
714c01b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabouzaid aabouzaid aabouzaid approved these changes

Assignees

@wollefitz wollefitz

Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wollefitz @aabouzaid