Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: hardcoding strategy for all components and removing ability to configure strategy #2155

Merged
merged 11 commits into from
Jul 30, 2024
Merged

refactor: hardcoding strategy for all components and removing ability to configure strategy #2155

merged 11 commits into from
Jul 30, 2024

Conversation

hamza-m-masood
Copy link
Contributor

@hamza-m-masood hamza-m-masood commented Jul 26, 2024 •
edited
Loading

Which problem does the PR fix?

closes: #2153
closes: #2160

What's in this PR?

Removing the option to configure the strategy for all components and hardcoding in the correct strategies for all components.

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@hamza-m-masood hamza-m-masood mentioned this pull request Jul 26, 2024
Closed
@hamza-m-masood hamza-m-masood changed the title strategy changes fix: strategy changes (operate tasklist) Jul 26, 2024
@hamza-m-masood hamza-m-masood marked this pull request as ready for review July 26, 2024 15:59
@hamza-m-masood hamza-m-masood requested a review from a team July 26, 2024 15:59
@hamza-m-masood hamza-m-masood self-assigned this Jul 26, 2024
@hamza-m-masood hamza-m-masood added this to the 8.6 Release Cycle milestone Jul 26, 2024
@hamza-m-masood hamza-m-masood added the kind/medic Tasks for the medic label Jul 26, 2024
@hamza-m-masood hamza-m-masood mentioned this pull request Jul 30, 2024
Closed
@hamza-m-masood hamza-m-masood changed the title fix: strategy changes (operate tasklist) fix: hardcoding strategy for all components and removing ability to configure strategy Jul 30, 2024
@aabouzaid aabouzaid changed the title fix: hardcoding strategy for all components and removing ability to configure strategy refactor: hardcoding strategy for all components and removing ability to configure strategy Jul 30, 2024
aabouzaid
aabouzaid approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@aabouzaid aabouzaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 👏

@hamza-m-masood hamza-m-masood merged commit 127162a into main Jul 30, 2024
51 of 52 checks passed
@hamza-m-masood hamza-m-masood deleted the strategy-changes branch July 30, 2024 19:41
@distro-ci distro-ci bot mentioned this pull request Jul 30, 2024
Merged
@github-actions github-actions bot added version/8.2 Camunda applications/cycle version version:8.2.32 version/8.3 Camunda applications/cycle version version/8.4 Camunda applications/cycle version labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabouzaid aabouzaid aabouzaid approved these changes

Assignees

@hamza-m-masood hamza-m-masood

Labels
kind/medic Tasks for the medic version/8.2 Camunda applications/cycle version version/8.3 Camunda applications/cycle version version/8.4 Camunda applications/cycle version
Projects
None yet
Milestone
8.6 Release Cycle
Development

Successfully merging this pull request may close these issues.

[ISSUE] Hardcoding deployment strategy for all components [ISSUE] Duplicate spec.strategy
2 participants
@hamza-m-masood @aabouzaid