Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add apiVersion and kind to PersistentVolumeClaims #2321

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aqeelat
Copy link

@aqeelat aqeelat commented Sep 8, 2024

Which problem does the PR fix?

#2214

What's in this PR?

Improving the definition of PVCs.

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@aqeelat
Copy link
Author

aqeelat commented Sep 8, 2024

I also fixed the indentation for charts/camunda-platform-8.2/charts/zeebe/templates/statefulset.yaml to match the rest of the statefulsets.

@CLAassistant
Copy link

CLAassistant commented Sep 17, 2024

CLA assistant check
All committers have signed the CLA.

@aqeelat
Copy link
Author

aqeelat commented Sep 19, 2024

The tests were initially failing in parts I didn't touch, but they succeed locally. Hopefully, all is good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants