Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: up tasklist timeoutSeconds to 5 #2417

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

jessesimpson36
Copy link
Contributor

@jessesimpson36 jessesimpson36 commented Oct 3, 2024

Which problem does the PR fix?

fixes #2386

What's in this PR?

We found that tasklist takes about 1.6 seconds to return a response to it's readinessProbe endpoint, so this PR will up the timeoutSeconds to accommodate for the extra time necessary.

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@jessesimpson36 jessesimpson36 marked this pull request as ready for review October 3, 2024 14:22
@jessesimpson36 jessesimpson36 self-assigned this Oct 3, 2024
Copy link
Contributor

@hisImminence hisImminence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks @jessesimpson36 and @hamza-m-masood!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE] In the Alpha chart (8.6), tasklist fails to connect to external Elasticsearch
2 participants