-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding schema.json file to alpha version #2537
Conversation
@aabouzaid I'm not sure what to do about the sensible defaults on the podDisruptionBudget. What do you think is the best solution here? Other than empty strings, here are all the sensible defaults I've made: f437894 |
The unit test called |
1487ade
to
0968aa4
Compare
48d4b0a
to
1458970
Compare
For the ci: |
37790eb
to
aabbfd5
Compare
charts/camunda-platform-alpha/test/unit/web-modeler/golden/deployment-restapi.golden.yaml
Outdated
Show resolved
Hide resolved
905ebba
to
f55b745
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you Hamza 🙌
Which problem does the PR fix?
closes: #2475
What's in this PR?
The readme-generator fails to generate a schema if any value is left empty. So, I added empty strings to each value that was left empty.
here is how you can generate a schema using the readme-generator command:
Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only
.After opening the PR: