Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove separated ingress functionality #2586

Merged
merged 1 commit into from
Nov 19, 2024
Merged

refactor: remove separated ingress functionality #2586

merged 1 commit into from
Nov 19, 2024

Conversation

aabouzaid
Copy link
Member

@aabouzaid aabouzaid commented Nov 18, 2024 •
edited
Loading

BREAKING CHANGE: remove separated ingress functionality and only keep the global combined ingress

Release-As: 0.0.0-8.7.0-alpha2

Which problem does the PR fix?

Fixes: #2264

What's in this PR?

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@aabouzaid
refactor: remove separated ingress functionality
3b5dd95 
BREAKING CHANGE: remove separated ingress functionality and only keep the global combined ingress

Release-As: 0.0.0-8.7.0-alpha2
@aabouzaid aabouzaid self-assigned this Nov 18, 2024
@aabouzaid aabouzaid marked this pull request as ready for review November 19, 2024 11:00
@aabouzaid aabouzaid requested a review from a team November 19, 2024 11:00
@aabouzaid aabouzaid added size/s Relative effort/time: Small kind/breaking-change A change that potentially causes other components to fail and needs a migration steps/guide labels Nov 19, 2024
@aabouzaid aabouzaid merged commit 3d12988 into main Nov 19, 2024
19 checks passed
@aabouzaid aabouzaid deleted the 2264-aa-remove-separated-ingress branch November 19, 2024 11:01
@aabouzaid aabouzaid mentioned this pull request Nov 19, 2024
Closed
@distro-ci distro-ci bot mentioned this pull request Nov 18, 2024
Merged
jonathanlukas pushed a commit that referenced this pull request Dec 13, 2024
@aabouzaid @jonathanlukas
refactor: remove separated ingress functionality (#2586)
e7bacb8 
BREAKING CHANGE: remove separated ingress functionality and only keep the global combined ingress

Release-As: 0.0.0-8.7.0-alpha2
This was referenced Jan 23, 2025
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aabouzaid aabouzaid

Labels
component/connectors component/console component/identity component/optimize component/web-modeler kind/breaking-change A change that potentially causes other components to fail and needs a migration steps/guide kind/refactor size/s Relative effort/time: Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK] Remove the separated ingress functionality for 8.7
1 participant
@aabouzaid