feat: add core unified prefix for Elasticsearch/OpenSearch #2643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabouzaid
force-pushed
the
2610-aa-add-core-index-prefix
branch
from
292cfdb to
cb09142
Compare
aabouzaid
force-pushed
the
2610-aa-add-core-index-prefix
branch
from
cb09142 to
2107883
Compare
aabouzaid
changed the title
ChrisKujawa
reviewed
Dec 6, 2024
Comment on lines
+274
to
+276
| {{- if .Values.core.index.prefix }} | ||
| prefix: {{ .Values.core.index.prefix | quote }} | ||
| {{- end }} |
There was a problem hiding this comment.
❌ I think here we wanted to keep the other prefix right?
ChrisKujawa
reviewed
Dec 6, 2024
Comment on lines
+26
to
+30
| settings: | ||
| {{- if .Values.core.index.prefix }} | ||
| index: | ||
| prefix: {{ .Values.core.index.prefix | quote }} | ||
| {{- end }} |
There was a problem hiding this comment.
❌ If we use for the ES exporter different prefix, then likely we need to use here the same for optimize
jonathanlukas
pushed a commit
that referenced
this pull request
Dec 13, 2024
This was referenced Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem does the PR fix?
Task: #2610
What's in this PR?
Added core unified prefix for Elasticsearch/OpenSearch.
Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only.After opening the PR: