-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kubectl port-froward to integration tests #2645
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution 🙌
I've left a couple of comments.
charts/camunda-platform-alpha/test/integration/testsuites/vars/files/testsuite-core.yaml
Outdated
Show resolved
Hide resolved
charts/camunda-platform-alpha/test/integration/testsuites/vars/files/testsuite-core.yaml
Outdated
Show resolved
Hide resolved
charts/camunda-platform-alpha/test/integration/testsuites/vars/files/testsuite-core.yaml
Outdated
Show resolved
Hide resolved
charts/camunda-platform-alpha/test/integration/testsuites/vars/files/testsuite-core.yaml
Outdated
Show resolved
Hide resolved
charts/camunda-platform-alpha/test/integration/testsuites/vars/files/testsuite-core.yaml
Outdated
Show resolved
Hide resolved
Also, don't forget to rebase to get the latest updates. |
edit to use the correct letter case.
"rebase" adding testing range
"rebase"
"after rebase"
Hi eng @aabouzaid 👋👋👋👋👋👋 |
type: exec | ||
range: | ||
- component: zeebe-gateway | ||
script: "{{.portforward}}/camunda-zeebe-gateway 26500:26500" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mabdelgowa, this will not work as port forwarding is a blocking command, and it will not return (will wait forever as it works).
So you can port forward and check at the same time in the script
section something like this:
[...]
range:
- component: "Zeebe Gateway"
serviceName: "camunda-zeebe-gateway"
servicePort: "26500"
[...]
script: |
(kubectl port-forward svc/{{ .serviceName }} {{ .servicePort }}:{{ .servicePort }} &
curl localhost:{{ .servicePort }})
Please ensure to test it locally first to ensure the proposed change works as expected (you can test it with any service, not necessarily Camunda deployment).
@aabouzaid I tested it locally after editing the script line to be like this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are now in the right direction. 👏
I've left a couple of notes.
charts/camunda-platform-alpha/test/integration/testsuites/vars/files/testsuite-core.yaml
Outdated
Show resolved
Hide resolved
charts/camunda-platform-alpha/test/integration/testsuites/vars/files/testsuite-core.yaml
Outdated
Show resolved
Hide resolved
charts/camunda-platform-alpha/test/integration/testsuites/vars/files/testsuite-core.yaml
Show resolved
Hide resolved
charts/camunda-platform-alpha/test/integration/testsuites/vars/files/testsuite-core.yaml
Outdated
Show resolved
Hide resolved
charts/camunda-platform-alpha/test/integration/testsuites/vars/files/testsuite-core.yaml
Show resolved
Hide resolved
@aabouzaid |
Add kubectl port-froward to integration tests