Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web-modeler): configure JWK Set URI for restapi component #2704

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jfriedenstab
Copy link
Contributor

@jfriedenstab jfriedenstab commented Dec 18, 2024

Which problem does the PR fix?

Closes https://github.com/camunda/web-modeler/issues/11510

What's in this PR?

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@github-actions github-actions bot added version/8.5 Camunda applications/cycle version version/8.6 Camunda applications/cycle version component/web-modeler version/alpha Camunda applications/cycle version (this is a pointer to alpha) labels Dec 18, 2024
@jfriedenstab jfriedenstab force-pushed the web-modeler-11510-jwk-set-uri branch from 52352c3 to 6a9b707 Compare December 19, 2024 16:30
@jfriedenstab jfriedenstab self-assigned this Dec 19, 2024
@jfriedenstab jfriedenstab force-pushed the web-modeler-11510-jwk-set-uri branch from 6a9b707 to b76bb88 Compare December 20, 2024 07:08
@jfriedenstab jfriedenstab force-pushed the web-modeler-11510-jwk-set-uri branch from b76bb88 to 3d41864 Compare January 2, 2025 20:56
@jfriedenstab jfriedenstab force-pushed the web-modeler-11510-jwk-set-uri branch from 3d41864 to e62cb5e Compare January 8, 2025 09:38
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that there was no golden file for configmap-restapi yet and used the opportunity to add it. This will also test the default value for jwk-set-uri.

Comment on lines +29 to +30
"global.identity.auth.connectors.existingSecret.name": "foo",
"global.identity.auth.core.existingSecret.name": "foo",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These values are required now given that global.testDeprecationFlags.existingSecretsMustBeSet was changed from warning to error. I think they're missing in all of the unit tests. At least, I added them here to be able to run the (new) tests for the restapi.

@jfriedenstab jfriedenstab marked this pull request as ready for review January 8, 2025 10:24
@jfriedenstab jfriedenstab requested a review from aabouzaid January 8, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/web-modeler version/alpha Camunda applications/cycle version (this is a pointer to alpha) version/8.5 Camunda applications/cycle version version/8.6 Camunda applications/cycle version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant