Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use integration-test-credentials for web modeler secret #2745

Merged
merged 1 commit into from
Jan 8, 2025
Merged

fix: use integration-test-credentials for web modeler secret #2745

merged 1 commit into from
Jan 8, 2025

Conversation

jessesimpson36
Copy link
Contributor

@jessesimpson36 jessesimpson36 commented Jan 8, 2025 •
edited
Loading

Which problem does the PR fix?

I made a mistake with #2742
where web modeler will not run due to improperly set up secret name in test values.yaml

What's in this PR?

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@github-actions github-actions bot added the version/8.3 Camunda applications/cycle version label Jan 8, 2025
@drodriguez-305 drodriguez-305 self-requested a review January 8, 2025 20:49
@jessesimpson36 jessesimpson36 changed the title Backport secrets autogen 8.3 fix: use integration-test-credentials for web modeler secret Jan 8, 2025
@jessesimpson36 jessesimpson36 merged commit b5e49ac into main Jan 8, 2025
16 of 18 checks passed
@jessesimpson36 jessesimpson36 deleted the backport-secrets-autogen-8.3 branch January 8, 2025 21:04
@distro-ci distro-ci bot mentioned this pull request Jan 9, 2025
Merged
@github-actions github-actions bot added the version:8.3.23 Issues and PRs related to chart version 8.3.23 label Jan 14, 2025
@distro-ci distro-ci bot mentioned this pull request Jan 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drodriguez-305 drodriguez-305 drodriguez-305 approved these changes

Assignees
No one assigned
Labels
version/8.3 Camunda applications/cycle version version:8.3.23 Issues and PRs related to chart version 8.3.23
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessesimpson36 @drodriguez-305