Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adding output to the clean job in rc-prep workflow #2754

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: adding output to the clean job in rc-prep workflow #2754

wants to merge 2 commits into from
+0 −1

Conversation

hamza-m-masood
Copy link
Contributor

Which problem does the PR fix?

What's in this PR?

I was using an output in the reset job that was missing in the clean job of the prepare-release-candidate.yaml workflow.

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@hamza-m-masood hamza-m-masood marked this pull request as ready for review January 10, 2025 10:33
aabouzaid
aabouzaid requested changes Jan 10, 2025
View reviewed changes
Copy link
Member

@aabouzaid aabouzaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output by the step is referenced but not defined.

@hamza-m-masood
Copy link
Contributor Author

Just keeping the needs value is enough to have a dependency: https://github.com/camunda/camunda-platform-helm/actions/runs/12713134354/job/35440335092?pr=2754

@hamza-m-masood
Copy link
Contributor Author

Maybe I now have to check whether each gh API call was successful and, if not, exit 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabouzaid aabouzaid aabouzaid requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area/ci tool/github-actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamza-m-masood @aabouzaid