-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infex #461 Update opensearch instance type in AWS examples #197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good 👍.
Just need to install pre-commit locally and run it again to fix it.
pre-commit install
pre-commit run --all-files
for future changes in this repository you shouldn't have linting problems anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of README mentionings with examples where we could update the instance type as well.
Looking at e.g.
Fixed them, thanks for pointing it out! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
As defined in this ticket the instance type of AWS opensearch examples has been modified from t3.medium search to m7i.large.search
In addition, the default value for the dedicated_master_node of Opensearch clusters has been changed from m4.large.search to m5.large search. The reason for this is that the m5 version is available in all regions, at a consistently cheaper price than the m4 one.