Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infex #461 Update opensearch instance type in AWS examples #197

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

bkenez
Copy link
Member

@bkenez bkenez commented Dec 17, 2024

As defined in this ticket the instance type of AWS opensearch examples has been modified from t3.medium search to m7i.large.search

In addition, the default value for the dedicated_master_node of Opensearch clusters has been changed from m4.large.search to m5.large search. The reason for this is that the m5 version is available in all regions, at a consistently cheaper price than the m4 one.

@bkenez bkenez requested a review from Langleu December 17, 2024 17:51
@CLAassistant
Copy link

CLAassistant commented Dec 17, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@Langleu Langleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good 👍.
Just need to install pre-commit locally and run it again to fix it.

pre-commit install
pre-commit run --all-files

for future changes in this repository you shouldn't have linting problems anymore.

Copy link
Member

@Langleu Langleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkenez
Copy link
Member Author

bkenez commented Dec 18, 2024

There are a couple of README mentionings with examples where we could update the instance type as well.

Looking at e.g.

Fixed them, thanks for pointing it out!
And also now with pre-commit.

Copy link
Member

@Langleu Langleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bkenez bkenez merged commit e0d0788 into main Dec 18, 2024
13 checks passed
@bkenez bkenez deleted the infex-461-update-instance-type branch December 18, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants