Skip to content

Commit

Permalink
deps: downgrade Netty due to incompatibility with grpc-java (#19755)
Browse files Browse the repository at this point in the history
## Description

Netty 4.1.111.Final is incompatible with grpc-java < 1.65.0 and >=
1.51.0. It can introduce buffer corruption at any point, which if you're
lucky is detected, but may also go unnoticed and result in garbage and
waste of time.

Wait until grpc-java releases a compatible version before updating to
4.1.111.Final. Note that this also blocks Spring Boot 3.3.1 which
depends on Netty 4.1.111.Final.

See:

- grpc/grpc-java#11284 (comment)
- https://github.com/grpc/grpc-java/releases/tag/v1.64.0

## Related issues

blocks #19581
blocks #19265
blocks #19264
blocks #19259
blocks #19258
  • Loading branch information
npepinpe committed Jun 26, 2024
2 parents b46d8ba + ded4741 commit d8c5c7a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .github/renovate.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,11 @@
"matchPackagePrefixes": ["org.jacoco"],
"allowedVersions": "!/0.8.9/"
},
{
"matchManagers": ["maven"],
"matchPackagePrefixes": ["io.netty"],
"allowedVersions": "<=4.1.110.Final"
},
{
"description" : "Exclude SNAPSHOT versions, renovate may suggest them for pre-release values.",
"matchManagers": ["maven"],
Expand Down
2 changes: 1 addition & 1 deletion parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
<version.mockito>5.12.0</version.mockito>
<version.model>7.7.0</version.model>
<version.msgpack>0.9.8</version.msgpack>
<version.netty>4.1.111.Final</version.netty>
<version.netty>4.1.110.Final</version.netty>
<version.objenesis>3.4</version.objenesis>
<version.opensearch>2.8.0</version.opensearch>
<version.opensearch.testcontainers>2.0.1</version.opensearch.testcontainers>
Expand Down

0 comments on commit d8c5c7a

Please sign in to comment.