Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate failing integration tests on stable/8.6 #26092

Closed
houssain-barouni opened this issue Dec 14, 2024 · 0 comments
Closed

Investigate failing integration tests on stable/8.6 #26092

houssain-barouni opened this issue Dec 14, 2024 · 0 comments
Assignees
@houssain-barouni
Labels
component/tasklist Related to the Tasklist component/team kind/bug Categorizes an issue or PR as a bug kind/flake Categorizes issue or PR as related to a flaky test version:8.7.0-alpha3

Comments

@houssain-barouni
Copy link
Collaborator

houssain-barouni commented Dec 14, 2024 •
edited
Loading

Describe the bug

To Reproduce

https://github.com/camunda/camunda/actions/workflows/tasklist-ci.yml?query=branch%3Astable%2F8.6
https://github.com/camunda/camunda/actions/runs/12285753672
@houssain-barouni houssain-barouni added kind/bug Categorizes an issue or PR as a bug kind/flake Categorizes issue or PR as related to a flaky test component/tasklist Related to the Tasklist component/team labels Dec 14, 2024
@houssain-barouni houssain-barouni self-assigned this Dec 14, 2024
@houssain-barouni houssain-barouni mentioned this issue Dec 23, 2024
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Dec 23, 2024
@houssain-barouni
Fix failing io.camunda.tasklist.es.SchemaCreationIT (#26348)
9697238 
## Description

<!-- Describe the goal and purpose of this PR. -->
One Tasklist ES Integration test is failing on `stable/8.6` since 2
weeks (`io.camunda.tasklist.es.SchemaCreationIT`)

https://github.com/camunda/camunda/actions/runs/12435031284/job/34719978871

It is caused by a concurrency situation where another test
`ElasticSearchSchemaManagementIT` running in parallel is polluting the
application context of this test by setting an extra `IndexDescriptor`
in `IndexSchemaValidator` bean.

When running Spring Boot tests in parallel, it is possible that they
share the same autowired beans if the beans are managed by the same
Spring ApplicationContext.

So here I marking the Tests updating the autowired beans with
`@DirtiesContext` so that it does not get used in other tests.

## Checklist

<!--- Please delete options that are not relevant. Boxes should be
checked by reviewer. -->
- [ ] for CI changes:
- [ ] structural/foundational changes signed off by [CI
DRI](https://github.com/cmur2)
- [ ]
[ci.yml](https://github.com/camunda/camunda/blob/main/.github/workflows/ci.yml)
modifications comply with ["Unified CI"
requirements](https://github.com/camunda/camunda/wiki/CI-&-Automation#workflow-inclusion-criteria)

## Related issues

closes #26092
@backport-action backport-action mentioned this issue Dec 23, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 23, 2024
@houssain-barouni
[Backport main] Fix failing io.camunda.tasklist.es.SchemaCreationIT (#…
f5c3654 
…26371)

# Description
Backport of #26348 to `main`.

relates to #26092
original author: @houssain-barouni
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@houssain-barouni houssain-barouni

Labels
component/tasklist Related to the Tasklist component/team kind/bug Categorizes an issue or PR as a bug kind/flake Categorizes issue or PR as related to a flaky test version:8.7.0-alpha3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@camundait @houssain-barouni