[Backport stable/8.0] Fix flaky MultiPartitionDeploymentLifecycleTest #10091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test was flaky because it was asserted that the COMPLETE commands and COMPLETED events were written in order. This is not always as the case. The COMPLETE commands are a result of partition 2 and 3 sending the command to partition 1. There is no guarantee that partition 1 will first receive both commands before it starts processing them. As long as we assert that we receive the COMPLETE command of partition X before the COMPLETED event of partition X the test should be accurate without being flaky. (cherry picked from commit 09718de)
(cherry picked from commit 369e5a1)
10 tasks
ghost
pushed a commit
that referenced
this pull request
Aug 17, 2022
|
Build failed: |
|
bors retry |
ghost
merged commit 
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
## Description <!-- Describe the goal and purpose of this PR. --> Cleanup OpenSearch Client, based on camunda/camunda-optimize#14637 ## Checklist <!--- Please delete options that are not relevant. Boxes should be checked by reviewer. --> - [ ] for CI changes: - [ ] structural/foundational changes signed off by [CI DRI](https://github.com/cmur2) - [ ] [ci.yml](https://github.com/camunda/camunda/blob/main/.github/workflows/ci.yml) modifications comply with ["Unified CI" requirements](https://github.com/camunda/camunda/wiki/CI-&-Automation#workflow-inclusion-criteria) ## Related issues closes [#10091](camunda/camunda-optimize#10091)
npepinpe
added
the
version:8.7.0-alpha2
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #10065 to
stable/8.0.relates to #9964