fix: throw correct error instead of InternalError #24680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenaschoenburg
approved these changes
Nov 13, 2024
entangled90
added
backport stable/8.3
entangled90
deleted the
cs-raise-correct-error-ConfigurationChangeCoordinatorImpl
branch
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-24680-to-stable/8.3
git worktree add --checkout .worktree/backport-24680-to-stable/8.3 backport-24680-to-stable/8.3
cd .worktree/backport-24680-to-stable/8.3
git reset --hard HEAD^
git cherry-pick -x b5d6ffdca4107fc3bd273dbe0ac067b42c547aa7
git push --force-with-lease |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-24680-to-stable/8.4
git worktree add --checkout .worktree/backport-24680-to-stable/8.4 backport-24680-to-stable/8.4
cd .worktree/backport-24680-to-stable/8.4
git reset --hard HEAD^
git cherry-pick -x b5d6ffdca4107fc3bd273dbe0ac067b42c547aa7
git push --force-with-lease |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
…or (#24689) # Description Backport of #24680 to `stable/8.6`. relates to original author: @entangled90
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
…or (#24688) # Description Backport of #24680 to `stable/8.5`. relates to original author: @entangled90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
InternalErrorwas thrown by mistake (which extendsVirtualMachineErrorand could case the VM to terminate.Correct error is now thrown