feat: add nested authentication input data #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmetzke
requested review from
nikku and
akulminskyi
and removed request for
a team
nikku
approved these changes
Aug 23, 2022
igpetrov
approved these changes
Aug 23, 2022
|
|
||
| @Override | ||
| public boolean equals(Object obj) { | ||
| if (this == obj) return true; |
There was a problem hiding this comment.
It's strange that auto-formatter doesn't catch such things. According to the Google Style Guide braces are always used
Suggested change
| if (this == obj) return true; | |
| if (this == obj) { | |
| return true; | |
| } |
| @Override | ||
| public boolean equals(Object obj) { | ||
| if (this == obj) return true; | ||
| if (obj == null) return false; |
There was a problem hiding this comment.
Suggested change
| if (obj == null) return false; | |
| if (obj == null) { | |
| return false; | |
| } |
| public boolean equals(Object obj) { | ||
| if (this == obj) return true; | ||
| if (obj == null) return false; | ||
| if (getClass() != obj.getClass()) return false; |
There was a problem hiding this comment.
Suggested change
| if (getClass() != obj.getClass()) return false; | |
| if (getClass() != obj.getClass()) { | |
| return false; | |
| } |
| @@ -51,12 +49,12 @@ public boolean equals(Object obj) { | |||
| if (obj == null) return false; | |||
There was a problem hiding this comment.
Suggested change
| if (obj == null) return false; | |
| if (obj == null) { | |
| return false; | |
| } |
| @@ -51,12 +49,12 @@ public boolean equals(Object obj) { | |||
| if (obj == null) return false; | |||
| if (getClass() != obj.getClass()) return false; | |||
There was a problem hiding this comment.
Suggested change
| if (getClass() != obj.getClass()) return false; | |
| if (getClass() != obj.getClass()) { | |
| return false; | |
| } |
| @@ -41,13 +41,28 @@ | |||
| } | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Suggestion: I am wondering, whether template should also contain one dynamic variable example?
There was a problem hiding this comment.
We could add a separate template with optional authentication to showcase this.
|
@igpetrov My bad for merging this early. |
No worries, those comments were minor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #9