fix(rest connector): add skip decoding field for rest outbound connector #3840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ztefanie
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...e/src/test/java/io/camunda/connector/http/base/client/apache/CustomApacheHttpClientTest.java
Fixed
Show resolved
Hide resolved
ztefanie
force-pushed
the
3694-add-skip-decoding-field-for-rest-outbound-connector
branch
from
cf8fa7e to
9d46417
Compare
johnBgood
reviewed
Jan 13, 2025
...ors/http/http-base/src/main/java/io/camunda/connector/http/base/model/HttpCommonRequest.java
Show resolved
Hide resolved
...ase/src/main/java/io/camunda/connector/http/base/client/apache/builder/parts/UrlEncoder.java
Show resolved
Hide resolved
...ors/http/http-base/src/main/java/io/camunda/connector/http/base/model/HttpCommonRequest.java
Show resolved
Hide resolved
...e/src/test/java/io/camunda/connector/http/base/client/apache/CustomApacheHttpClientTest.java
Show resolved
Hide resolved
| @@ -407,6 +407,16 @@ | |||
| "type" : "zeebe:input" | |||
| }, | |||
| "type" : "Boolean" | |||
| }, { | |||
There was a problem hiding this comment.
just to be sure: did you run the maven command or did you add these lines manually?
There was a problem hiding this comment.
This is added by the maven command. The changes in the gitlab connector json are done manually.
There was a problem hiding this comment.
Maybe should we update the version in HttpJsonFunction ?
There was a problem hiding this comment.
I updated the version and ran maven generate templates command, but now the changes to the ".json" files are removed? Is it correct to run the command in the http/rest/ subfolder? I am confused, why they were added first and now they are removed 🤔
sbuettner
reviewed
Jan 13, 2025
...ors/http/http-base/src/main/java/io/camunda/connector/http/base/model/HttpCommonRequest.java
Show resolved
Hide resolved
sbuettner
reviewed
Jan 13, 2025
...ors/http/http-base/src/main/java/io/camunda/connector/http/base/model/HttpCommonRequest.java
Outdated
Show resolved
Hide resolved
sbuettner
reviewed
Jan 13, 2025
...ors/http/http-base/src/main/java/io/camunda/connector/http/base/model/HttpCommonRequest.java
Outdated
Show resolved
Hide resolved
sbuettner
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Info
Questions
Related issues
closes #3694
Checklist
no milestonelabel. (not sure which milestone i should set it too 🤔 )