feat(runtime): fail without retries on ConnectorInputException #3844
+41
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnBgood
reviewed
Jan 13, 2025
| if (ex instanceof ConnectorException connectorException) { | ||
| errorCode = connectorException.getErrorCode(); | ||
| Throwable cause = connectorException.getCause(); | ||
| if (cause instanceof ConnectorInputException) { |
There was a problem hiding this comment.
maybe check if ex instanceof ConnectorInputException because currently your test might if I replace jobHandler by :
var jobHandler =
newConnectorJobHandler(
context -> {
throw new ConnectorInputException(
"expected Connector Input Exception", new RuntimeException("cause"));
});There was a problem hiding this comment.
This is because one can create the exception using new ConnectorInputException.. or using the builder, and it will lead to different exceptions.
There was a problem hiding this comment.
Good point 👍 Thanks for mentioning and explaining. I adjusted it and added it to the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set retries to zero, when ConnectorInputException is thrown.
Related issues
closes #3806
Checklist
no milestonelabel.