feat(sql): Add JSON support #3972
Open
+194
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
connectors/jdbc/src/main/java/io/camunda/connector/jdbc/model/client/JdbiJsonHelper.java
Fixed
Show fixed
Hide fixed
sbuettner
reviewed
Feb 7, 2025
connectors/jdbc/src/main/java/io/camunda/connector/jdbc/model/client/JdbiJsonHelper.java
Outdated
Show resolved
Hide resolved
ztefanie
force-pushed
the
3895-sql-connector-add-json-support
branch
from
8765e80 to
b3eaa4c
Compare
ztefanie
force-pushed
the
3895-sql-connector-add-json-support
branch
from
b3eaa4c to
4b5a24d
Compare
johnBgood
reviewed
Feb 10, 2025
.../jdbc/src/test/java/io/camunda/connector/jdbc/integration/JdbiJdbcClientIntegrationTest.java
Outdated
Show resolved
Hide resolved
connectors/jdbc/src/main/java/io/camunda/connector/jdbc/model/client/JdbiJsonHelper.java
Outdated
Show resolved
Hide resolved
connectors/jdbc/src/main/java/io/camunda/connector/jdbc/model/client/JdbiJsonHelper.java
Show resolved
Hide resolved
ztefanie
force-pushed
the
3895-sql-connector-add-json-support
branch
from
efae941 to
cde0ea0
Compare
johnBgood
reviewed
Feb 11, 2025
| } | ||
|
|
||
| private static boolean isJsonColumn(String databaseProductName, String columnTypeName) { | ||
| Map<String, Set<String>> dbTypeMapping = new HashMap<>(); |
There was a problem hiding this comment.
minor detail, but it can be a static field in this class created with Map.of(....,...,....,...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added JSON parsing for string columns.
Added Uni Tests for all sql specific json columns
Related issues
closes #3895
Checklist
no milestonelabel.