fix: Tests no longer randomly get stuck when waiting for idle state

camunda · Jan 12, 2022 · 3069d9c · 3069d9c
1 parent 1954fc7
commit 3069d9c
Showing 1 changed file with 13 additions and 15 deletions.
diff --git a/src/main/java/io/camunda/zeebe/process/test/testengine/IdleStateMonitor.java b/src/main/java/io/camunda/zeebe/process/test/testengine/IdleStateMonitor.java
@@ -52,29 +52,27 @@ public void addCallback(final Runnable callback) {
   }
 
   private void checkIdleState() {
-    if (isInIdleState()) {
-      scheduleNotification();
-    } else {
-      cancelNotification();
+    synchronized (idleStateNotifier) {
+      if (isInIdleState()) {
+        scheduleNotification();
+      } else {
+        cancelNotification();
+      }
     }
   }
 
   private void scheduleNotification() {
-    synchronized (idleStateNotifier) {
-      idleStateNotifier = createIdleStateNotifier();
-      try {
-        TIMER.schedule(idleStateNotifier, GRACE_PERIOD);
-      } catch (IllegalStateException e) {
-        // thrown - among others - if task was cancelled before it could be scheduled
-        // do nothing in this case
-      }
+    idleStateNotifier = createIdleStateNotifier();
+    try {
+      TIMER.schedule(idleStateNotifier, GRACE_PERIOD);
+    } catch (IllegalStateException e) {
+      // thrown - among others - if task was cancelled before it could be scheduled
+      // do nothing in this case
     }
   }
 
   private void cancelNotification() {
-    synchronized (idleStateNotifier) {
-      idleStateNotifier.cancel();
-    }
+    idleStateNotifier.cancel();
   }
 
   private boolean isInIdleState() {