Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use System's line separator #141

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Use System's line separator #141

merged 1 commit into from
Jan 13, 2022

Conversation

remcowesterhoud
Copy link
Contributor

@remcowesterhoud remcowesterhoud commented Jan 13, 2022 •
edited
Loading

Description

I've cherry-picked the line endings fix from the branch stability-improvements.

Related issues

closes #119

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

@remcowesterhoud remcowesterhoud merged commit 13a663b into main Jan 13, 2022
@remcowesterhoud remcowesterhoud deleted the 119-line-seperators branch January 13, 2022 08:37
@remcowesterhoud remcowesterhoud mentioned this pull request Jan 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't build test library locally
2 participants
@remcowesterhoud @pihme